Skip to content

Fix public actions type #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 6, 2024
Merged

Fix public actions type #261

merged 6 commits into from
Aug 6, 2024

Conversation

plusminushalf
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cc5e8a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024 •
edited
Loading

size-limit report 📦

Path Size
permissionless (esm) 39.85 KB (+0.01% 🔺)
permissionless (cjs) 118.94 KB (+0.01% 🔺)
permissionless (minimal surface - tree-shaking) 10.09 KB (0%)

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.28289% with 53 lines in your changes missing coverage. Please review.

Project coverage is 85.20%. Comparing base (407d4db) to head (cc5e8a9).
Report is 8 commits behind head on main.

Files Patch % Lines
.../permissionless/clients/decorators/smartAccount.ts 44.82% 32 Missing ⚠️
...rmissionless/actions/smartAccount/writeContract.ts 27.77% 13 Missing ⚠️
packages/permissionless/actions/erc7579.ts 90.90% 6 Missing ⚠️
...ermissionless/actions/erc7579/isModuleInstalled.ts 96.29% 1 Missing ⚠️
...missionless/actions/smartAccount/deployContract.ts 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   84.97%   85.20%   +0.22%     
==========================================
  Files         109      109              
  Lines       13595    13998     +403     
  Branches      407      407              
==========================================
+ Hits        11553    11927     +374     
- Misses       2036     2065      +29     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusminushalf plusminushalf merged commit b6c6c6c into main Aug 6, 2024
9 checks passed
@plusminushalf plusminushalf deleted the fix-public-actions branch August 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofgazso kristofgazso kristofgazso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plusminushalf @kristofgazso